require "rails_helper" require "base64" require "stringio" require "tempfile" RSpec.describe "Vehicles" do describe "unauthenticated access" do it "redirects vehicle pages to identification" do get vehicles_path expect(response).to redirect_to(identify_path) end it "does not create fuel entries" do vehicle = create(:vehicle, current_odometer: 10_000) expect do post vehicle_fuel_entries_path(vehicle), params: { fuel_entry: valid_fuel_entry_params } end.not_to change(FuelEntry, :count) expect(response).to redirect_to(identify_path) end it "does not create maintenance entries" do vehicle = create(:vehicle, current_odometer: 10_000) create(:maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change") expect do post vehicle_maintenance_entries_path(vehicle), params: { maintenance_entry: valid_maintenance_entry_params } end.not_to change(MaintenanceEntry, :count) expect(response).to redirect_to(identify_path) end end describe "GET /" do before { identify_user } it "renders the active vehicle index" do active_vehicle = create(:vehicle, make: "Ford", model: "F-150", active: true) inactive_vehicle = create(:vehicle, make: "Chevrolet", model: "Silverado", active: false) get root_path expect(response).to have_http_status(:ok) expect(response.body).to include("Vehicles") expect(response.body).to include(active_vehicle.model) expect(response.body).not_to include(inactive_vehicle.model) end end describe "GET /vehicles" do before { identify_user } it "shows active vehicles by default" do active_vehicle = create(:vehicle, make: "Ford", model: "F-150", active: true) inactive_vehicle = create(:vehicle, make: "Chevrolet", model: "Silverado", active: false) get vehicles_path expect(response).to have_http_status(:ok) expect(response.body).to include(active_vehicle.model) expect(response.body).not_to include(inactive_vehicle.model) end it "shows inactive vehicles when requested" do active_vehicle = create(:vehicle, make: "Ford", model: "F-150", active: true) inactive_vehicle = create(:vehicle, make: "Chevrolet", model: "Silverado", active: false) get vehicles_path(status: "inactive") expect(response).to have_http_status(:ok) expect(response.body).not_to include(active_vehicle.model) expect(response.body).to include(inactive_vehicle.model) end it "shows all vehicles when requested" do active_vehicle = create(:vehicle, make: "Ford", model: "F-150", active: true) inactive_vehicle = create(:vehicle, make: "Chevrolet", model: "Silverado", active: false) get vehicles_path(status: "all") expect(response).to have_http_status(:ok) expect(response.body).to include(active_vehicle.model) expect(response.body).to include(inactive_vehicle.model) end it "shows upcoming maintenance names on vehicle tiles" do vehicle = create(:vehicle, current_odometer: 14_750) create( :maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change", mileage_interval: 5_000, baseline_odometer: 10_000, baseline_date: Date.current ) get vehicles_path expect(response).to have_http_status(:ok) expect(response.body).to include("vehicle-card--upcoming") expect(response.body).to include("Upcoming maintenance") expect(response.body).to include("Oil Change") end it "shows overdue maintenance names on vehicle tiles" do vehicle = create(:vehicle, current_odometer: 15_000) create( :maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change", mileage_interval: 5_000, baseline_odometer: 10_000, baseline_date: Date.current ) get vehicles_path expect(response).to have_http_status(:ok) expect(response.body).to include("vehicle-card--overdue") expect(response.body).to include("Overdue maintenance") expect(response.body).to include("Oil Change") end end describe "GET /vehicles/:id" do before { identify_user } it "shows vehicle details and display-only history sections" do vehicle = create(:vehicle, make: "Ford", model: "F-150") older_fuel_entry = create(:fuel_entry, vehicle: vehicle, odometer: 11_000, date: Date.current - 2.days) newer_fuel_entry = create(:fuel_entry, vehicle: vehicle, odometer: 12_000, date: Date.current - 1.day) older_maintenance_entry = create( :maintenance_entry, vehicle: vehicle, name: "Oil Change", notes: "Older oil change", date: Date.current - 2.days ) newer_maintenance_entry = create( :maintenance_entry, vehicle: vehicle, name: "Oil Change", notes: "Newer oil change", date: Date.current - 1.day ) get vehicle_path(vehicle) expect(response).to have_http_status(:ok) expect(response.body).to include(vehicle.make) expect(response.body).to include(vehicle.model) expect(response.body).to include("Vehicle Information") expect(response.body).to include("Maintenance Schedules") expect(response.body).to include("Manage maintenance schedules") expect(response.body).to include("Fuel History") expect(response.body).to include("Maintenance History") expect(response.body).to include(vehicle.maintenance_schedules.first.maintenance_type) expect(response.body).to include("12,000") expect(response.body).to include("11,000") expect(response.body).to include(newer_maintenance_entry.notes) expect(response.body).to include(older_maintenance_entry.notes) expect(response.body.index("12,000")).to be < response.body.index("11,000") expect(response.body.index(newer_maintenance_entry.notes)).to be < response.body.index(older_maintenance_entry.notes) expect(response.body.index("Record Fuel")).to be < response.body.index("Record Maintenance") expect(response.body.index("Maintenance History")).to be < response.body.index("Fuel History") end it "shows overdue maintenance alerts" do vehicle = create(:vehicle, current_odometer: 15_000) create( :maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change", mileage_interval: 5_000, baseline_odometer: 10_000, baseline_date: Date.current ) get vehicle_path(vehicle) expect(response).to have_http_status(:ok) expect(response.body).to include("Overdue maintenance") expect(response.body).to include("Oil Change is overdue") expect(response.body).to include("aria-label=\"Maintenance attention needed\"") expect(response.body).to include("Record Maintenance") expect(response.body).to include("
") end it "shows upcoming maintenance warnings" do vehicle = create(:vehicle, current_odometer: 14_750) create( :maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change", mileage_interval: 5_000, baseline_odometer: 10_000, baseline_date: Date.current ) get vehicle_path(vehicle) expect(response).to have_http_status(:ok) expect(response.body).to include("Upcoming maintenance") expect(response.body).to include("Oil Change is upcoming") expect(response.body).to include("aria-label=\"Maintenance attention needed\"") expect(response.body).to include("Record Maintenance") expect(response.body).to include("
") end it "hides the top maintenance alert area when maintenance is current" do vehicle = create(:vehicle, current_odometer: 10_100) create(:maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change") create( :maintenance_entry, vehicle: vehicle, name: "Oil Change", odometer: 10_000, date: Date.current ) get vehicle_path(vehicle) expect(response).to have_http_status(:ok) expect(response.body).not_to include("aria-label=\"Maintenance attention needed\"") end it "shows no-history maintenance status without marking it overdue" do vehicle = create(:vehicle, current_odometer: 10_100) create( :maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change", mileage_interval: 5_000, baseline_odometer: 10_000, baseline_date: Date.current ) get vehicle_path(vehicle) expect(response).to have_http_status(:ok) expect(response.body).to include("No Maintenance History") expect(response.body).to include("Oil Change has no matching maintenance entry yet") expect(response.body).not_to include("Oil Change is overdue") end it "shows image counts without loading image URLs" do vehicle = create(:vehicle) fuel_entry = create(:fuel_entry, vehicle: vehicle) fuel_entry.images.attach(image_attachment("receipt.png")) get vehicle_path(vehicle) expect(response).to have_http_status(:ok) expect(response.body).to include("Show images (1)") expect(response.body).not_to include("/rails/active_storage") end it "logs overdue notifications only when schedule status changes" do vehicle = create(:vehicle, current_odometer: 15_000) schedule = create( :maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change", mileage_interval: 5_000, baseline_odometer: 10_000, baseline_date: Date.current ) allow(Rails.logger).to receive(:warn) get vehicle_path(vehicle) get vehicle_path(vehicle) expect(schedule.reload.last_status).to eq("overdue") expect(Rails.logger).to have_received(:warn).once.with(/Maintenance schedule overdue: vehicle_id=#{vehicle.id}/) end end describe "maintenance schedule CRUD" do before { identify_user } it "lists maintenance schedules" do vehicle = create(:vehicle) create(:maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change") get vehicle_maintenance_schedules_path(vehicle) expect(response).to have_http_status(:ok) expect(response.body).to include("Maintenance Schedules") expect(response.body).to include("Oil Change") end it "creates a maintenance schedule" do vehicle = create(:vehicle) expect do post vehicle_maintenance_schedules_path(vehicle), params: { maintenance_schedule: valid_maintenance_schedule_params } end.to change(MaintenanceSchedule, :count).by(1) expect(response).to redirect_to(vehicle_maintenance_schedules_path(vehicle)) expect(MaintenanceSchedule.last.baseline_odometer).to eq(10_000) end it "rejects invalid maintenance schedule params" do vehicle = create(:vehicle) expect do post vehicle_maintenance_schedules_path(vehicle), params: { maintenance_schedule: valid_maintenance_schedule_params.merge(mileage_interval: 0) } end.not_to change(MaintenanceSchedule, :count) expect(response).to have_http_status(:unprocessable_content) expect(response.body).to include("prevented this maintenance schedule from being saved") end it "updates a maintenance schedule" do vehicle = create(:vehicle) schedule = create(:maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change") patch vehicle_maintenance_schedule_path(vehicle, schedule), params: { maintenance_schedule: valid_maintenance_schedule_params.merge(maintenance_type: "Tire Rotation") } expect(response).to redirect_to(vehicle_maintenance_schedules_path(vehicle)) expect(schedule.reload.maintenance_type).to eq("Tire Rotation") end it "soft deactivates a maintenance schedule" do vehicle = create(:vehicle) schedule = create(:maintenance_schedule, vehicle: vehicle, active: true) expect do patch deactivate_vehicle_maintenance_schedule_path(vehicle, schedule) end.not_to change(MaintenanceSchedule, :count) expect(response).to redirect_to(vehicle_maintenance_schedules_path(vehicle)) expect(schedule.reload).not_to be_active end end describe "POST /vehicles/:vehicle_id/fuel_entries" do before { identify_user } it "creates a fuel entry and records the identified user" do vehicle = create(:vehicle, current_odometer: 10_000) expect do post vehicle_fuel_entries_path(vehicle), params: { fuel_entry: valid_fuel_entry_params } end.to change(FuelEntry, :count).by(1) expect(response).to redirect_to(vehicle_path(vehicle)) expect(FuelEntry.last.updated_by_user).to eq(@identified_user) end it "creates a fuel entry with multiple images" do vehicle = create(:vehicle, current_odometer: 10_000) expect do post vehicle_fuel_entries_path(vehicle), params: { fuel_entry: valid_fuel_entry_params.merge(images: [ uploaded_image("receipt-one.png"), uploaded_image("receipt-two.png") ]) } end.to change(FuelEntry, :count).by(1) expect(response).to redirect_to(vehicle_path(vehicle)) expect(FuelEntry.last.images.count).to eq(2) end it "rejects duplicate images when creating a fuel entry" do vehicle = create(:vehicle, current_odometer: 10_000) expect do post vehicle_fuel_entries_path(vehicle), params: { fuel_entry: valid_fuel_entry_params.merge(images: [ uploaded_image("receipt-one.png", png_bytes), uploaded_image("receipt-two.png", png_bytes) ]) } end.not_to change(FuelEntry, :count) expect(response).to have_http_status(:unprocessable_content) expect(response.body).to include("This image is already attached to this entry") end it "rejects unsupported fuel entry images" do vehicle = create(:vehicle, current_odometer: 10_000) expect do post vehicle_fuel_entries_path(vehicle), params: { fuel_entry: valid_fuel_entry_params.merge(images: [ uploaded_file("receipt.txt", "text/plain", "not an image") ]) } end.not_to change(FuelEntry, :count) expect(response).to have_http_status(:unprocessable_content) expect(response.body).to include("Images must be JPEG or PNG") end it "updates the vehicle odometer when the fuel odometer is newer" do vehicle = create(:vehicle, current_odometer: 10_000) post vehicle_fuel_entries_path(vehicle), params: { fuel_entry: valid_fuel_entry_params.merge(odometer: 10_500) } expect(vehicle.reload.current_odometer).to eq(10_500) end it "saves equal fuel odometer entries without changing the vehicle odometer" do vehicle = create(:vehicle, current_odometer: 10_000) expect do post vehicle_fuel_entries_path(vehicle), params: { fuel_entry: valid_fuel_entry_params.merge(odometer: 10_000) } end.to change(FuelEntry, :count).by(1) expect(vehicle.reload.current_odometer).to eq(10_000) end it "rejects fuel odometer entries below the current vehicle odometer" do vehicle = create(:vehicle, current_odometer: 10_000) expect do post vehicle_fuel_entries_path(vehicle), params: { fuel_entry: valid_fuel_entry_params.merge(odometer: 9_999) } end.not_to change(FuelEntry, :count) expect(response).to have_http_status(:unprocessable_content) expect(response.body).to include("prevented this fuel entry from being saved") expect(vehicle.reload.current_odometer).to eq(10_000) end it "renders validation errors for invalid fuel params" do vehicle = create(:vehicle, current_odometer: 10_000) expect do post vehicle_fuel_entries_path(vehicle), params: { fuel_entry: valid_fuel_entry_params.merge(gallons_pumped: 0) } end.not_to change(FuelEntry, :count) expect(response).to have_http_status(:unprocessable_content) expect(response.body).to include("prevented this fuel entry from being saved") end end describe "POST /vehicles/:vehicle_id/maintenance_entries" do before { identify_user } it "creates a maintenance entry and records the identified user" do vehicle = create(:vehicle, current_odometer: 10_000) create(:maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change") expect do post vehicle_maintenance_entries_path(vehicle), params: { maintenance_entry: valid_maintenance_entry_params } end.to change(MaintenanceEntry, :count).by(1) expect(response).to redirect_to(vehicle_path(vehicle)) expect(MaintenanceEntry.last.updated_by_user).to eq(@identified_user) end it "creates a maintenance entry with multiple images" do vehicle = create(:vehicle, current_odometer: 10_000) create(:maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change") expect do post vehicle_maintenance_entries_path(vehicle), params: { maintenance_entry: valid_maintenance_entry_params.merge(images: [ uploaded_image("service-one.png"), uploaded_image("service-two.png") ]) } end.to change(MaintenanceEntry, :count).by(1) expect(response).to redirect_to(vehicle_path(vehicle)) expect(MaintenanceEntry.last.images.count).to eq(2) end it "rejects duplicate images when creating a maintenance entry" do vehicle = create(:vehicle, current_odometer: 10_000) create(:maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change") expect do post vehicle_maintenance_entries_path(vehicle), params: { maintenance_entry: valid_maintenance_entry_params.merge(images: [ uploaded_image("service-one.png", png_bytes), uploaded_image("service-two.png", png_bytes) ]) } end.not_to change(MaintenanceEntry, :count) expect(response).to have_http_status(:unprocessable_content) expect(response.body).to include("This image is already attached to this entry") end it "updates the vehicle odometer when the maintenance odometer is newer" do vehicle = create(:vehicle, current_odometer: 10_000) create(:maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change") post vehicle_maintenance_entries_path(vehicle), params: { maintenance_entry: valid_maintenance_entry_params.merge(odometer: 10_500) } expect(vehicle.reload.current_odometer).to eq(10_500) end it "saves older maintenance odometers without lowering the vehicle odometer" do vehicle = create(:vehicle, current_odometer: 10_000) create(:maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change") expect do post vehicle_maintenance_entries_path(vehicle), params: { maintenance_entry: valid_maintenance_entry_params.merge(odometer: 9_750) } end.to change(MaintenanceEntry, :count).by(1) expect(vehicle.reload.current_odometer).to eq(10_000) end it "warns and logs when maintenance odometer is more than 500 miles behind" do vehicle = create(:vehicle, current_odometer: 10_000) create(:maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change") allow(Rails.logger).to receive(:warn) post vehicle_maintenance_entries_path(vehicle), params: { maintenance_entry: valid_maintenance_entry_params.merge(odometer: 9_499) } expect(response).to redirect_to(vehicle_path(vehicle)) expect(flash[:warning]).to include("more than 500 miles behind") expect(Rails.logger).to have_received(:warn).with(/vehicle_id=#{vehicle.id}.*entry_odometer=9499/) end it "rejects maintenance entries with an unmatched schedule name" do vehicle = create(:vehicle, current_odometer: 10_000) create(:maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change") expect do post vehicle_maintenance_entries_path(vehicle), params: { maintenance_entry: valid_maintenance_entry_params.merge(name: "Tire Rotation") } end.not_to change(MaintenanceEntry, :count) expect(response).to have_http_status(:unprocessable_content) expect(response.body).to include("prevented this maintenance entry from being saved") end it "renders validation errors for invalid maintenance params" do vehicle = create(:vehicle, current_odometer: 10_000) create(:maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change") expect do post vehicle_maintenance_entries_path(vehicle), params: { maintenance_entry: valid_maintenance_entry_params.merge(notes: "") } end.not_to change(MaintenanceEntry, :count) expect(response).to have_http_status(:unprocessable_content) expect(response.body).to include("prevented this maintenance entry from being saved") end end describe "GET /vehicles/:vehicle_id/fuel_entries/:id/images" do before { identify_user } it "loads fuel entry images inline" do vehicle = create(:vehicle) fuel_entry = create(:fuel_entry, vehicle: vehicle) fuel_entry.images.attach(image_attachment("receipt.png")) get images_vehicle_fuel_entry_path(vehicle, fuel_entry) expect(response).to have_http_status(:ok) expect(response.body).to include("receipt.png") expect(response.body).to include("/rails/active_storage") expect(response.body).not_to include("/rails/active_storage/representations") end end describe "GET /vehicles/:vehicle_id/fuel_entries/:id/new_images" do before { identify_user } it "loads an inline upload form for an existing fuel entry" do vehicle = create(:vehicle) fuel_entry = create(:fuel_entry, vehicle: vehicle) get new_images_vehicle_fuel_entry_path(vehicle, fuel_entry) expect(response).to have_http_status(:ok) expect(response.body).to include("Upload images") expect(response.body).to include(images_vehicle_fuel_entry_path(vehicle, fuel_entry)) end end describe "POST /vehicles/:vehicle_id/fuel_entries/:id/images" do before { identify_user } it "adds images to an existing fuel entry and renders thumbnails immediately" do vehicle = create(:vehicle) fuel_entry = create(:fuel_entry, vehicle: vehicle) expect do post images_vehicle_fuel_entry_path(vehicle, fuel_entry), params: { fuel_entry: { images: [ uploaded_image("receipt-one.png"), uploaded_image("receipt-two.png") ] } } end.to change { fuel_entry.reload.images.count }.from(0).to(2) expect(response).to have_http_status(:ok) expect(response.body).to include("receipt-one") expect(response.body).to include("receipt-two") expect(response.body).to include("/rails/active_storage") end it "adds images to an older fuel entry without rerunning odometer validation" do vehicle = create(:vehicle, current_odometer: 10_000) fuel_entry = create(:fuel_entry, vehicle: vehicle, odometer: 10_000) vehicle.update!(current_odometer: 15_000) expect do post images_vehicle_fuel_entry_path(vehicle, fuel_entry), params: { fuel_entry: { images: [ "", uploaded_image("receipt.png") ] } } end.to change { fuel_entry.reload.images.count }.from(0).to(1) expect(response).to have_http_status(:ok) expect(response.body).to include("receipt") expect(response.body).to include("/rails/active_storage") end it "rejects an empty existing fuel entry image upload" do vehicle = create(:vehicle) fuel_entry = create(:fuel_entry, vehicle: vehicle) expect do post images_vehicle_fuel_entry_path(vehicle, fuel_entry), params: { fuel_entry: { images: [ "" ] } } end.not_to change { fuel_entry.reload.images.count } expect(response).to have_http_status(:unprocessable_content) expect(response.body).to include("Images must be selected") expect(response.body).to include("Upload images") end it "rejects unsupported images for an existing fuel entry" do vehicle = create(:vehicle) fuel_entry = create(:fuel_entry, vehicle: vehicle) expect do post images_vehicle_fuel_entry_path(vehicle, fuel_entry), params: { fuel_entry: { images: [ uploaded_file("receipt.txt", "text/plain", "not an image") ] } } end.not_to change { fuel_entry.reload.images.count } expect(response).to have_http_status(:unprocessable_content) expect(response.body).to include("Images must be JPEG or PNG") expect(response.body).to include("Upload images") end it "rejects duplicate images for an existing fuel entry" do vehicle = create(:vehicle) fuel_entry = create(:fuel_entry, vehicle: vehicle) fuel_entry.images.attach(image_attachment("receipt.png")) expect do post images_vehicle_fuel_entry_path(vehicle, fuel_entry), params: { fuel_entry: { images: [ uploaded_image("receipt-copy.png", png_bytes) ] } } end.not_to change { fuel_entry.reload.images.count } expect(response).to have_http_status(:unprocessable_content) expect(response.body).to include("This image is already attached to this entry") expect(response.body).to include("Upload images") end it "allows the same image on a different fuel entry" do vehicle = create(:vehicle) first_entry = create(:fuel_entry, vehicle: vehicle) second_entry = create(:fuel_entry, vehicle: vehicle) first_entry.images.attach(image_attachment("receipt.png")) expect do post images_vehicle_fuel_entry_path(vehicle, second_entry), params: { fuel_entry: { images: [ uploaded_image("receipt-copy.png", png_bytes) ] } } end.to change { second_entry.reload.images.count }.from(0).to(1) expect(response).to have_http_status(:ok) end end describe "GET /vehicles/:vehicle_id/maintenance_entries/:id/images" do before { identify_user } it "loads maintenance entry images inline" do vehicle = create(:vehicle) maintenance_entry = create(:maintenance_entry, vehicle: vehicle) maintenance_entry.images.attach(image_attachment("service.png")) get images_vehicle_maintenance_entry_path(vehicle, maintenance_entry) expect(response).to have_http_status(:ok) expect(response.body).to include("service.png") expect(response.body).to include("/rails/active_storage") expect(response.body).not_to include("/rails/active_storage/representations") end end describe "GET /vehicles/:vehicle_id/maintenance_entries/:id/new_images" do before { identify_user } it "loads an inline upload form for an existing maintenance entry" do vehicle = create(:vehicle) maintenance_entry = create(:maintenance_entry, vehicle: vehicle) get new_images_vehicle_maintenance_entry_path(vehicle, maintenance_entry) expect(response).to have_http_status(:ok) expect(response.body).to include("Upload images") expect(response.body).to include(images_vehicle_maintenance_entry_path(vehicle, maintenance_entry)) end end describe "POST /vehicles/:vehicle_id/maintenance_entries/:id/images" do before { identify_user } it "adds images to an existing maintenance entry and renders thumbnails immediately" do vehicle = create(:vehicle) create(:maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change") maintenance_entry = create(:maintenance_entry, vehicle: vehicle) expect do post images_vehicle_maintenance_entry_path(vehicle, maintenance_entry), params: { maintenance_entry: { images: [ uploaded_image("service-one.png"), uploaded_image("service-two.png") ] } } end.to change { maintenance_entry.reload.images.count }.from(0).to(2) expect(response).to have_http_status(:ok) expect(response.body).to include("service-one") expect(response.body).to include("service-two") expect(response.body).to include("/rails/active_storage") end it "ignores blank image params for an existing maintenance entry" do vehicle = create(:vehicle) create(:maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change") maintenance_entry = create(:maintenance_entry, vehicle: vehicle) expect do post images_vehicle_maintenance_entry_path(vehicle, maintenance_entry), params: { maintenance_entry: { images: [ "", uploaded_image("service.png") ] } } end.to change { maintenance_entry.reload.images.count }.from(0).to(1) expect(response).to have_http_status(:ok) expect(response.body).to include("service") end it "rejects unsupported images for an existing maintenance entry" do vehicle = create(:vehicle) create(:maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change") maintenance_entry = create(:maintenance_entry, vehicle: vehicle) expect do post images_vehicle_maintenance_entry_path(vehicle, maintenance_entry), params: { maintenance_entry: { images: [ uploaded_file("service.txt", "text/plain", "not an image") ] } } end.not_to change { maintenance_entry.reload.images.count } expect(response).to have_http_status(:unprocessable_content) expect(response.body).to include("Images must be JPEG or PNG") expect(response.body).to include("Upload images") end it "rejects duplicate images for an existing maintenance entry" do vehicle = create(:vehicle) create(:maintenance_schedule, vehicle: vehicle, maintenance_type: "Oil Change") maintenance_entry = create(:maintenance_entry, vehicle: vehicle) maintenance_entry.images.attach(image_attachment("service.png")) expect do post images_vehicle_maintenance_entry_path(vehicle, maintenance_entry), params: { maintenance_entry: { images: [ uploaded_image("service-copy.png", png_bytes) ] } } end.not_to change { maintenance_entry.reload.images.count } expect(response).to have_http_status(:unprocessable_content) expect(response.body).to include("This image is already attached to this entry") expect(response.body).to include("Upload images") end end describe "DELETE /vehicles/:vehicle_id/fuel_entries/:fuel_entry_id/images/:attachment_id" do before { identify_user } it "deletes one fuel entry image" do vehicle = create(:vehicle) fuel_entry = create(:fuel_entry, vehicle: vehicle) fuel_entry.images.attach(image_attachment("receipt.png")) attachment = fuel_entry.images.first expect do delete vehicle_fuel_entry_image_path(vehicle, fuel_entry, attachment) end.to change { fuel_entry.reload.images.count }.from(1).to(0) expect(response).to redirect_to(images_vehicle_fuel_entry_path(vehicle, fuel_entry)) end end describe "DELETE /vehicles/:vehicle_id/maintenance_entries/:maintenance_entry_id/images/:attachment_id" do before { identify_user } it "deletes one maintenance entry image" do vehicle = create(:vehicle) maintenance_entry = create(:maintenance_entry, vehicle: vehicle) maintenance_entry.images.attach(image_attachment("service.png")) attachment = maintenance_entry.images.first expect do delete vehicle_maintenance_entry_image_path(vehicle, maintenance_entry, attachment) end.to change { maintenance_entry.reload.images.count }.from(1).to(0) expect(response).to redirect_to(images_vehicle_maintenance_entry_path(vehicle, maintenance_entry)) end end describe "GET /vehicles/new" do before { identify_user } it "renders the form" do get new_vehicle_path expect(response).to have_http_status(:ok) expect(response.body).to include("New Vehicle") end end describe "POST /vehicles" do before { identify_user } it "creates a vehicle with valid params" do expect do post vehicles_path, params: { vehicle: valid_vehicle_params } end.to change(Vehicle, :count).by(1) expect(response).to redirect_to(vehicle_path(Vehicle.last)) expect(Vehicle.last.vin).to eq("ABC123") end it "rejects invalid params" do expect do post vehicles_path, params: { vehicle: valid_vehicle_params.merge(make: "", vin: "") } end.not_to change(Vehicle, :count) expect(response).to have_http_status(:unprocessable_content) expect(response.body).to include("prevented this vehicle from being saved") end end describe "GET /vehicles/:id/edit" do before { identify_user } it "renders the form" do vehicle = create(:vehicle) get edit_vehicle_path(vehicle) expect(response).to have_http_status(:ok) expect(response.body).to include("Edit Vehicle") end end describe "PATCH /vehicles/:id" do before { identify_user } it "updates a vehicle with valid params" do vehicle = create(:vehicle, make: "Ford") patch vehicle_path(vehicle), params: { vehicle: valid_vehicle_params.merge(make: "Toyota") } expect(response).to redirect_to(vehicle_path(vehicle)) expect(vehicle.reload.make).to eq("Toyota") end it "rejects invalid params" do vehicle = create(:vehicle, make: "Ford") patch vehicle_path(vehicle), params: { vehicle: valid_vehicle_params.merge(make: "") } expect(response).to have_http_status(:unprocessable_content) expect(vehicle.reload.make).to eq("Ford") expect(response.body).to include("prevented this vehicle from being saved") end end describe "DELETE /vehicles/:id" do before { identify_user } it "deactivates the vehicle instead of deleting it" do vehicle = create(:vehicle, active: true) expect do delete vehicle_path(vehicle) end.not_to change(Vehicle, :count) expect(response).to redirect_to(vehicles_path) expect(vehicle.reload).not_to be_active end end def valid_vehicle_params { make: "Ford", model: "F-150", year: Date.current.year, color: "White", vin: "abc123", licence_plate: "FLT1234", current_odometer: 10_000, fuel_tank_size: 26.0, active: "1" } end def valid_fuel_entry_params { odometer: 10_250, gallons_pumped: 18.25, price_paid: 47.62, date: Date.current } end def valid_maintenance_entry_params { name: "Oil Change", notes: "Oil change performed by Fleet Service Center.", odometer: 10_250, cost: 89.95, date: Date.current } end def valid_maintenance_schedule_params { maintenance_type: "Oil Change", mileage_interval: 5_000, time_interval: 180, baseline_odometer: 10_000, baseline_date: Date.current, active: "1" } end def identify_user(user = create(:user)) @identified_user = user access_key = AccessKey.current post session_path, params: { name: user.name, email: user.email, key: access_key.raw_key } end def image_attachment(filename) { io: StringIO.new(png_bytes), filename: filename, content_type: "image/png" } end def uploaded_image(filename, content = nil) uploaded_file(filename, "image/png", content || "image content for #{filename}") end def uploaded_file(filename, content_type, content) file = Tempfile.new([ File.basename(filename, ".*"), File.extname(filename) ]) file.binmode file.write(content) file.rewind Rack::Test::UploadedFile.new(file.path, content_type) end def png_bytes Base64.decode64("iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMCAO+/p9sAAAAASUVORK5CYII=") end end